Skip to content

Comments

refactor(semantic): move CatchParameter exit node handling to visit methods#12632

Closed
camc314 wants to merge 1 commit intomainfrom
c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods
Closed

refactor(semantic): move CatchParameter exit node handling to visit methods#12632
camc314 wants to merge 1 commit intomainfrom
c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 30, 2025

No description provided.

This was referenced Jul 30, 2025
Merged
Merged
@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 30, 2025
@camc314 camc314 marked this pull request as ready for review July 30, 2025 13:32
@camc314 camc314 mentioned this pull request Jul 30, 2025
Closed
@camc314 camc314 requested a review from Dunqing as a code owner July 30, 2025 13:32
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jul 30, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 30, 2025
Closed
Closed
Merged
@camc314 camc314 changed the base branch from c/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methods to graphite-base/12632 July 30, 2025 13:33
@camc314 camc314 mentioned this pull request Jul 30, 2025
Merged
@camc314 camc314 changed the base branch from graphite-base/12632 to c/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methods July 30, 2025 13:37
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12632 will not alter performance

Comparing c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods (3924fd7) with main (109fc3c)

Summary

✅ 34 untouched benchmarks

overlookmotel
overlookmotel reviewed Jul 30, 2025
View reviewed changes
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems with this one.

But what did you think of the 2nd part of my comment?: #12524 (comment)

Personally I think we should consider codegen-ing walk_children_* functions. It wouldn't be hard to do, and would make these new visit methods simpler.

@camc314 camc314 changed the base branch from c/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methods to graphite-base/12632 July 30, 2025 15:05
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jul 30, 2025

Yes i agree we should code-gen the walk_children functions.

Shall we merge this stack first, then code-gen the walk chidren fns?

@camc314 camc314 force-pushed the graphite-base/12632 branch from 76e6ef6 to 18d3502 Compare July 30, 2025 15:10
@camc314 camc314 force-pushed the c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods branch from c890607 to 1d29607 Compare July 30, 2025 15:10
@camc314 camc314 changed the base branch from graphite-base/12632 to c/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methods July 30, 2025 15:10
@overlookmotel
Copy link
Member

overlookmotel commented Jul 30, 2025

Yes i agree we should code-gen the walk_children functions.

Shall we merge this stack first, then code-gen the walk chidren fns?

I think it'd be better to codegen the walk children functions first, so this stack can use them. It'd make these PRs smaller and easier to review.

@overlookmotel
Copy link
Member

overlookmotel commented Jul 30, 2025

Opened oxc-project/backlog#186 to discuss possible solutions for visitation "hooks".

@camc314
Copy link
Contributor Author

camc314 commented Jul 30, 2025

Perfect, sounds good

@graphite-app graphite-app bot changed the base branch from c/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methods to graphite-base/12632 July 31, 2025 08:40
@graphite-app graphite-app bot force-pushed the c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods branch from 1d29607 to e483e40 Compare July 31, 2025 08:59
@graphite-app graphite-app bot force-pushed the graphite-base/12632 branch from 18d3502 to 109fc3c Compare July 31, 2025 08:59
@graphite-app graphite-app bot changed the base branch from graphite-base/12632 to main July 31, 2025 09:00
@graphite-app graphite-app bot force-pushed the c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods branch from e483e40 to 3924fd7 Compare July 31, 2025 09:00
@camc314 camc314 closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel left review comments

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314 @overlookmotel